Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22394#discussion_r216874181
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaPruningSuite.scala
---
@@ -156,20 +156,24 @@ class ParquetSchemaPruningSuite
}
private def testSchemaPruning(testName: String)(testThunk: => Unit) {
- withSQLConf(SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key -> "true") {
- test(s"Spark vectorized reader - without partition data column -
$testName") {
+ test(s"Spark vectorized reader - without partition data column -
$testName") {
+ withSQLConf(SQLConf.PARQUET_VECTORIZED_READER_ENABLED.key -> "true")
{
--- End diff --
Yea, the call of `test` only registers the test function, it is not
actually invoked within the `withSQLConf`. We shouldn't wrap `test` inside
`withSQLConf`. Good catch.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
