Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/22344#discussion_r217070658
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -68,22 +68,42 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
object SpecialLimits extends Strategy {
override def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
case ReturnAnswer(rootPlan) => rootPlan match {
- case Limit(IntegerLiteral(limit), Sort(order, true, child))
- if limit < conf.topKSortFallbackThreshold =>
- TakeOrderedAndProjectExec(limit, order, child.output,
planLater(child)) :: Nil
- case Limit(IntegerLiteral(limit), Project(projectList, Sort(order,
true, child)))
- if limit < conf.topKSortFallbackThreshold =>
- TakeOrderedAndProjectExec(limit, order, projectList,
planLater(child)) :: Nil
+ case Limit(IntegerLiteral(limit), s@Sort(order, true, child)) =>
+ if (limit < conf.topKSortFallbackThreshold) {
--- End diff --
@viirya sorry to be a little late to the party. This pattern is repeated 4x
can you just most into a helper function?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
