Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22404#discussion_r217153096
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/DownloadFile.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.network.shuffle;
+
+/**
+ * A handle on the file used when fetching remote data to disk. Used to
ensure the lifecycle of
+ * writing the data, reading it back, and then cleaning it up is followed.
Specific implementations
+ * may also handle encryption. The data can be read only via
DownloadFileWritableChannel,
+ * which ensures data is not read until after the writer is closed.
+ */
+public interface DownloadFile {
+ /**
+ * Delete the file.
+ *
+ * @return <code>true</code> if and only if the file or directory is
+ * successfully deleted; <code>false</code> otherwise
+ */
+ public boolean delete();
+
+ /**
+ * A channel for writing data to the file. This special channel allows
access to the data for
+ * reading, after the channel is closed, via {@link
DownloadFileWritableChannel#closeAndRead()}.
+ */
+ public DownloadFileWritableChannel openForWriting();
+
+ /**
+ * The path of the file, intended only for debug purposes.
+ * @return
--- End diff --
These are just nits, but you can put the text on the line above in the tag
here
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
