Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22316#discussion_r217251795
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -416,7 +426,7 @@ class RelationalGroupedDataset protected[sql](
new RelationalGroupedDataset(
df,
groupingExprs,
- RelationalGroupedDataset.PivotType(pivotColumn.expr,
values.map(Literal.apply)))
+ RelationalGroupedDataset.PivotType(pivotColumn.expr,
values.map(lit(_).expr)))
--- End diff --
@MaxGekk, just for doubly doubly sure, shell we
`Try(...).getOrElse(lit(...).expr)`? Looks at least there's one case of a
potential behaviour change about scale and precision.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
