Github user suryag10 commented on the issue:

    https://github.com/apache/spark/pull/22433
  
    > Thank you for your first contribution, @suryag10 .
    > 
    > * Could you file a SPARK JIRA issue since this is a code change?
    Sure.
    > * Could you update the PR title like the other PRs? e.g. 
`[SPARK-XXX][SQL][K8S] ...`?
    Sure.
    > 
    > And, just out of curious, do we need this change?
    > 
    > ```shell
    > - exec "${SPARK_HOME}"/sbin/spark-daemon.sh submit $CLASS 1 --name 
"Thrift JDBC/ODBC Server" "$@"
    > + exec "${SPARK_HOME}"/sbin/spark-daemon.sh submit $CLASS 1 --name 
"Thrift-JDBC-ODBC-Server" "$@"
    > ```
    
    Without the above change, it fails to start the driver pod as well. Spaces, 
"/" are not allowed for the "name" in the kubernetes world.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to