Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22443#discussion_r218308258
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala
---
@@ -17,29 +17,28 @@
package org.apache.spark.sql.execution.benchmark
-import java.io.{File, FileOutputStream, OutputStream}
+import java.io.File
import scala.util.{Random, Try}
-import org.scalatest.{BeforeAndAfterEachTestData, Suite, TestData}
-
import org.apache.spark.SparkConf
-import org.apache.spark.SparkFunSuite
import org.apache.spark.sql.{DataFrame, SparkSession}
import org.apache.spark.sql.functions.monotonically_increasing_id
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.internal.SQLConf.ParquetOutputTimestampType
import org.apache.spark.sql.types.{ByteType, Decimal, DecimalType,
TimestampType}
-import org.apache.spark.util.{Benchmark, Utils}
+import org.apache.spark.util.{Benchmark, BenchmarkBase =>
FileBenchmarkBase, Utils}
/**
* Benchmark to measure read performance with Filter pushdown.
- * To run this:
- * build/sbt "sql/test-only *FilterPushdownBenchmark"
- *
- * Results will be written to
"benchmarks/FilterPushdownBenchmark-results.txt".
+ * To run this benchmark:
+ * 1. without sbt: bin/spark-submit --class <this class> <spark sql test
jar>
+ * 2. build/sbt "sql/test:runMain <this class>"
+ * 3. generate result: SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt
"sql/test:runMain <this class>"
--- End diff --
Yes, It can print the output to console if `SPARK_GENERATE_BENCHMARK_FILES`
not set.
https://github.com/apache/spark/blob/4e8ac6edd5808ca8245b39d804c6d4f5ea9d0d36/core/src/main/scala/org/apache/spark/util/Benchmark.scala#L59-L63
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
