GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/22512
[SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite failures when the interpreter
mode enabled
## What changes were proposed in this pull request?
This pr fixed test failures in `SQLQueryTestSuite` when the interpreter
mode enabled. This pr addressed the two cases below;
- The current `InterpretedMutableProjection` can't handle `UnsafeRow` in
the internal buffer `mutableRow`. `AggregationIterator` uses
`MutableProjection` in that manner and `GenerateMutableProjection` can handle
`UnsafeRow` as buffer internally.
- `Literal` returns different a typed value between codegen and interpreter
modes in some cases, e.g., `Literal(1, LongType)` returns a long value for the
codegen mode and returns an int value for the interpreter mode. So,
`InterpretedUnsafeProjection` fails when running `SQLQueryTestSuite`.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maropu/spark InterpreterTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22512.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22512
----
commit 39c5e92713b86f342e756591235f9cbe25126f90
Author: Takeshi Yamamuro <yamamuro@...>
Date: 2018-09-21T04:25:53Z
Fix test failures with the interpreter mode enabled
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
