Github user seancxmao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22461#discussion_r219386919
  
    --- Diff: 
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
 ---
    @@ -442,6 +442,8 @@ class OracleIntegrationSuite extends 
DockerJDBCIntegrationSuite with SharedSQLCo
           .option("lowerBound", "2018-07-06")
           .option("upperBound", "2018-07-20")
           .option("numPartitions", 3)
    +      .option("oracle.jdbc.mapDateToTimestamp", "false")
    --- End diff --
    
    ok. I will add notes to 
http://spark.apache.org/docs/latest/sql-programming-guide.html#jdbc-to-other-databases,
 and will also add comments to the code.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to