Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22466#discussion_r219443041
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -321,8 +321,19 @@ private[hive] class HiveClientImpl(
override def dropDatabase(
name: String,
ignoreIfNotExists: Boolean,
- cascade: Boolean): Unit = withHiveState {
- client.dropDatabase(name, true, ignoreIfNotExists, cascade)
+ cascade: Boolean): Unit = {
+ var isExternalDB = false
+ try {
+ val db: CatalogDatabase = getDatabase(name)
+ isExternalDB = db.properties.getOrElse("isExternal",
"false").matches("true")
+ }
+ catch {
--- End diff --
please pull catch to 1 level up inline with the close brace of try
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
