Github user seancxmao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22461#discussion_r219537942
  
    --- Diff: 
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
 ---
    @@ -462,6 +468,12 @@ class OracleIntegrationSuite extends 
DockerJDBCIntegrationSuite with SharedSQLCo
           .option("lowerBound", "2018-07-04 03:30:00.0")
           .option("upperBound", "2018-07-27 14:11:05.0")
           .option("numPartitions", 2)
    +      // oracle.jdbc.mapDateToTimestamp defaults to true. If this flag is 
not disabled, column d
    +      // (Oracle DATE) will be resolved as Catalyst Timestamp, which will 
fail test result
    +      // comparison. E.g. Expected 2018-07-06 while Actual 2018-07-06 
00:00:00.0.
    --- End diff --
    
    OK, I will remove duplicate description.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to