Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22488#discussion_r219729655
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetBenchmark.scala ---
@@ -242,75 +248,20 @@ object DatasetBenchmark {
benchmark
}
- def main(args: Array[String]): Unit = {
- val spark = SparkSession.builder
- .master("local[*]")
- .appName("Dataset benchmark")
- .getOrCreate()
+ val spark = SparkSession.builder
+ .master("local[*]")
+ .appName("Dataset benchmark")
+ .getOrCreate()
--- End diff --
Can we move this SparkSession building part into `benchmark()` function and
before `runBenchmark("Dataset Benchmark")`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
