Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22419
https://github.com/apache/spark/pull/22419#issuecomment-423454727
This approach looks good to me cuz it makes the implementation simpler.
But, there is one thing I worry about; truncating is a kind of rounding (Is it
ok to extend `RoundBase` for `Truncate`)? This is just a naming issue of
`RoundBase` though. cc: @gatorsmile
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
