Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22526#discussion_r219891354
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -685,7 +685,7 @@ private[ui] class TaskDataSource(
private var _tasksToShow: Seq[TaskData] = null
- override def dataSize: Int = taskCount(stage)
+ override def dataSize: Int = store.taskCount(stage.stageId,
stage.attemptId).toInt
--- End diff --
nit: after this change, the function `taskCount()` is only referenced by
`totalTasks`, we can inline that.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
