Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/21632#discussion_r220413857
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala
---
@@ -159,6 +169,31 @@ class DecisionTreeRegressorSuite extends MLTest with
DefaultReadWriteTest {
}
}
+ test("training with sample weights") {
+ val df = linearRegressionData
+ val numClasses = 0
+ val testParams = Seq(5, 10)
+ for (maxDepth <- testParams) {
+ val estimator = new DecisionTreeRegressor()
+ .setImpurity("variance")
+ .setMaxDepth(maxDepth)
+ .setMaxBins(100)
+ .setMinWeightFractionPerNode(0.05)
+ .setSeed(123)
+ // TODO: This doesn't look correct, need to debug to figure out what
is wrong with tolerance
--- End diff --
fixed after some debugging
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
