Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22596#discussion_r221688986
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java
---
@@ -174,9 +174,12 @@ public void reset() {
if (consumer != null) {
consumer.freeArray(array);
// the call to consumer.allocateArray may trigger a spill
- // which in turn access this instance and eventually re-enter this
method and try to free the array again.
- // by setting the array to null and its length to 0 we effectively
make the spill code-path a no-op.
- // setting the array to null also indicates that it has already been
de-allocated which prevents a double de-allocation in free().
+ // which in turn access this instance and eventually re-enter this
method
+ // and try to free the array again.
+ // by setting the array to null and its length to 0
--- End diff --
`by` -> `By`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
