Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22671#discussion_r223771001
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
---
@@ -332,7 +332,9 @@ class KafkaSinkSuite extends StreamTest with
SharedSQLContext with KafkaTest {
var ex: Exception = null
try {
ex = intercept[StreamingQueryException] {
- writer = createKafkaWriter(input.toDF(), withTopic = Some(topic))()
+ writer = createKafkaWriter(input.toDF(),
--- End diff --
@srowen Thank you. I thought about it initially, but went with a
conservative fix.
> it seems like it's a generally good idea to not let anything block that
long in tests
I agree.
> In fact KafkaContinuousSinkSuite sets it to 1000. We should standardize
that too
Yeah.. wasn't sure on value to set. If we think 1 second is a good enough
timeout setting, i can change.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
