Github user 10110346 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22594#discussion_r224286853
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala
 ---
    @@ -70,6 +70,8 @@ class FileScanRDD(
     
       private val ignoreCorruptFiles = 
sparkSession.sessionState.conf.ignoreCorruptFiles
       private val ignoreMissingFiles = 
sparkSession.sessionState.conf.ignoreMissingFiles
    +  // only for test
    +  private val inputMetricsTest = 
sparkSession.sessionState.conf.contains("spark.inputmetrics.test")
    --- End diff --
    
    If this place is controlled by `spark.testing`, other unit tests may fail.
    Yeah, I agree with you ,this a simple change, it is  better to drop this.
    thanks @srowen 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to