Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22661#discussion_r224934912
  
    --- Diff: core/src/test/scala/org/apache/spark/benchmark/Benchmark.scala ---
    @@ -200,11 +200,12 @@ private[spark] object Benchmark {
       def getProcessorName(): String = {
         val cpu = if (SystemUtils.IS_OS_MAC_OSX) {
           Utils.executeAndGetOutput(Seq("/usr/sbin/sysctl", "-n", 
"machdep.cpu.brand_string"))
    +        .stripLineEnd
    --- End diff --
    
    Ur.. I'm not a fan to piggy-backing. Okay.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to