Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/22712#discussion_r224957118
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/MapType.scala ---
@@ -73,6 +74,90 @@ case class MapType(
override private[spark] def existsRecursively(f: (DataType) => Boolean):
Boolean = {
f(this) || keyType.existsRecursively(f) ||
valueType.existsRecursively(f)
}
+
+ private[this] class OrderedWrapper {
+ var isOrdered: Boolean = false
--- End diff --
I prefer not to make this mutable if we can. That can be a source of some
pretty weird errors if we move from an unordered to an ordered map. Why do you
need this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
