Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20999#discussion_r225074416
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
 ---
    @@ -293,6 +293,31 @@ class AstBuilder(conf: SQLConf) extends 
SqlBaseBaseVisitor[AnyRef] with Logging
         }
       }
     
    +  /**
    +   * Create a partition specification map with filters.
    +   */
    +  override def visitDropPartitionSpec(
    +      ctx: DropPartitionSpecContext): Seq[Expression] = {
    --- End diff --
    
    nit: can we move `withOrigin(ctx)` here? i.e.
    ```
    def xxx(): T = withOrigin(ctx) {
      ...
    }
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to