Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22514#discussion_r225082659
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ddl.scala ---
@@ -34,11 +34,16 @@ import org.apache.spark.sql.types._
* @param tableDesc the metadata of the table to be created.
* @param mode the data writing mode
* @param query an optional logical plan representing data to write into
the created table.
+ * @param useExternalSerde whether to use external serde to write data,
e.g., Hive Serde. Currently
--- End diff --
This is because all rules related to conversion to data source are located
in `RelationConversions`.
If we loose this requirement, we can avoid this flag and let
`CreateHiveTableAsSelectCommand` decide to convert it to data source or not.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
