Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22713#discussion_r225119359
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -112,8 +112,8 @@ object EliminateView extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan transform {
// The child should have the same output attributes with the View
operator, so we simply
// remove the View operator.
- case View(_, output, child) =>
- assert(output == child.output,
+ case v @ View(_, output, child) =>
+ assert(v.sameOutput(child),
--- End diff --
+1 for adding a test case. BTW does it impact end-users? If it does we need
to backport it to 2.4.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
