Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21669
I went through the code again, and the main thing for me is that following
this whole "steps" thing in the k8s backend still seems really hard to me. It
feels like related code gets scattered around into a bunch of different places
for no reason that I can detect.
e.g. adding the "HadoopConfigSpec" thing to "KubernetesConf" just seems to
require a bunch of changes in unrelated places instead of just reading that
information from the underlying configuration where it's actually needed.
But that's not going to be fixed here. When/if I have time I might try to
figure this stuff out.
I still noticed some remaining style issues but at this point those don't
matter. The functionality looks ok so, pending the new test run, I'll merge
this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
