Github user attilapiros commented on a diff in the pull request:
https://github.com/apache/spark/pull/22279#discussion_r225310671
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
---
@@ -103,6 +103,14 @@ private[spark] class MetricsSystem private (
sinks.foreach(_.start)
}
+ // Same as start but this method only registers sinks
--- End diff --
I can just fully agree with you.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
