Github user ifilonenko commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22608#discussion_r225631577
  
    --- Diff: bin/docker-image-tool.sh ---
    @@ -71,18 +71,29 @@ function build {
         --build-arg
         base_img=$(image_ref spark)
       )
    -  local BASEDOCKERFILE=${BASEDOCKERFILE:-"$IMG_PATH/spark/Dockerfile"}
    -  local 
PYDOCKERFILE=${PYDOCKERFILE:-"$IMG_PATH/spark/bindings/python/Dockerfile"}
    -  local RDOCKERFILE=${RDOCKERFILE:-"$IMG_PATH/spark/bindings/R/Dockerfile"}
    +  local 
BASEDOCKERFILE=${BASEDOCKERFILE:-"$IMG_PATH/main/dockerfiles/spark/Dockerfile"}
    +  local 
PYDOCKERFILE=${PYDOCKERFILE:-"$IMG_PATH/main/dockerfiles/spark/bindings/python/Dockerfile"}
    +  local 
KDOCKERFILE=${KDOCKERFILE:-"$IMG_PATH/test/dockerfiles/spark/kerberos/Dockerfile"}
    --- End diff --
    
    It is a docker image builder, so it seems to be an appropriate place. 
Especially, since it’s the first stage in our integration tests. But am open 
to opinions. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to