Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22646#discussion_r225819586
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1115,9 +1126,38 @@ object SQLContext {
})
}
}
- def createConverter(cls: Class[_], dataType: DataType): Any => Any =
dataType match {
- case struct: StructType => createStructConverter(cls,
struct.map(_.dataType))
- case _ => CatalystTypeConverters.createToCatalystConverter(dataType)
+ def createConverter(t: Type, dataType: DataType): Any => Any = (t,
dataType) match {
--- End diff --
Yea .. was just thinking of moving this func to there .. looks ugly that
this file getting long.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
