Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22756#discussion_r226141315
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
    @@ -125,8 +125,13 @@ class BisectingKMeansModel private[ml] (
       /**
        * Computes the sum of squared distances between the input points and 
their corresponding cluster
        * centers.
    +   *
    +   * @deprecated This method is deprecated and will be removed in 3.0.0. 
Use ClusteringEvaluator
    +   *             instead. You can also get the cost on the training 
dataset in the summary.
        */
       @Since("2.0.0")
    +  @deprecated("This method is deprecated and will be removed in 3.0.0. Use 
ClusteringEvaluator " +
    --- End diff --
    
    It looks reasonable to me to deprecate it in 2.4 so that we can remove it 
in 3.0, if this is the last one. Then we can have a consistent ML API in 3.0 
after removing these deprecated APIs.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to