Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22732#discussion_r226145051
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala ---
    @@ -393,4 +393,30 @@ class UDFSuite extends QueryTest with SharedSQLContext 
{
           checkAnswer(df, Seq(Row("12"), Row("24"), Row("3null"), Row(null)))
         }
       }
    +
    +  test("SPARK-25044 Verify null input handling for primitive types - with 
udf()") {
    +    val udf1 = udf({(x: Long, y: Any) => x * 2 + (if (y == null) 1 else 
0)})
    --- End diff --
    
    nit `udf((x: Long, y: Any) => x * 2 + (if (y == null) 1 else 0))`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to