Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22764#discussion_r226384584
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
    @@ -310,4 +317,6 @@ class BisectingKMeansSummary private[clustering] (
         predictionCol: String,
         featuresCol: String,
         k: Int,
    -    numIter: Int) extends ClusteringSummary(predictions, predictionCol, 
featuresCol, k, numIter)
    +    numIter: Int,
    +    @Since("2.4.0") val trainingCost: Double)
    --- End diff --
    
    oh wait. If the final goal is to have a consistent ML API in 3.0, do we 
have to put this new API in 2.4?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to