Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226520350
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -932,6 +935,23 @@ trait ScalaReflection {
tpe.dealias.erasure.typeSymbol.asClass.fullName
}
+ /**
+ * Returns the nullability of the input parameter types of the scala
function object.
+ *
+ * Note that this only works with Scala 2.11, and the information
returned may be inaccurate if
+ * used with a different Scala version.
--- End diff --
shall we explicitly return seq of true if it's not scala 2.11? Then the
behavior is more predictable than `may be inaccurate`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
