GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/22776
[SPARK-25779][SQL][TESTS] Remove SQL query tests for function documentation by DESCRIBE FUNCTION at SQLQueryTestSuite Currently, there are some tests testing function descriptions: ```bash $ grep -ir "describe function" sql/core/src/test/resources/sql-tests/inputs sql/core/src/test/resources/sql-tests/inputs/json-functions.sql:describe function to_json; sql/core/src/test/resources/sql-tests/inputs/json-functions.sql:describe function extended to_json; sql/core/src/test/resources/sql-tests/inputs/json-functions.sql:describe function from_json; sql/core/src/test/resources/sql-tests/inputs/json-functions.sql:describe function extended from_json; ``` Looks there are not quite good points about testing them since we're not going to test documentation itself. For `DESCRIBE FCUNTION` functionality itself, they are already being tested here and there. See the test failures in https://github.com/apache/spark/pull/18749 (where I added examples to function descriptions) We better remove those tests so that people don't add such tests in the SQL tests. ## How was this patch tested? Manual. You can merge this pull request into a Git repository by running: $ git pull https://github.com/HyukjinKwon/spark SPARK-25779 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22776.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22776 ---- commit 7f4cd6d00b3bb27f123a5be4a7f5d4979d513c35 Author: hyukjinkwon <gurwls223@...> Date: 2018-10-19T09:28:27Z Remove SQL query tests for function documentation by DESCRIBE FUNCTION at SQLQueryTestSuite ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org