Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22547#discussion_r226790252
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/streaming/InputStream.java
---
@@ -17,14 +17,18 @@
package org.apache.spark.sql.sources.v2.reader.streaming;
-import org.apache.spark.sql.sources.v2.reader.ReadSupport;
+import org.apache.spark.annotation.InterfaceStability;
+import org.apache.spark.sql.execution.streaming.BaseStreamingSource;
/**
- * A base interface for streaming read support. This is package private
and is invisible to data
- * sources. Data sources should implement concrete streaming read support
interfaces:
- * {@link MicroBatchReadSupport} or {@link ContinuousReadSupport}.
+ * An interface representing a readable data stream in a streaming query.
It's responsible to manage
+ * the offsets of the streaming source in this streaming query.
+ *
+ * Data sources should implement concrete input stream interfaces: {@link
MicroBatchInputStream} and
+ * {@link ContinuousInputStream}.
*/
-interface StreamingReadSupport extends ReadSupport {
+@InterfaceStability.Evolving
+public interface InputStream extends BaseStreamingSource {
--- End diff --
`InputStream` conflicts with a well-known JVM class,
[`java.io.InputStream`](https://docs.oracle.com/javase/9/docs/api/java/io/InputStream.html).
I think this should be renamed to be more specific to a streaming table scan.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
