Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22745#discussion_r227355335
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
 ---
    @@ -1787,3 +1787,75 @@ case class ValidateExternalType(child: Expression, 
expected: DataType)
         ev.copy(code = code, isNull = input.isNull)
       }
     }
    +
    +object GetArrayFromMap {
    +  abstract class Source
    +  case class Key() extends Source
    +  case class Value() extends Source
    --- End diff --
    
    I don't have a strong opinion, but shall we use enum?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to