Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22749#discussion_r227681844
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1087,7 +1087,7 @@ class Dataset[T] private[sql](
// Note that we do this before joining them, to enable the join
operator to return null for one
// side, in cases like outer-join.
val left = {
- val combined = if (this.exprEnc.flat) {
+ val combined = if
(!this.exprEnc.objSerializer.dataType.isInstanceOf[StructType]) {
--- End diff --
shall we create a method in `ExpressionEncoder` for this check?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
