Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22809#discussion_r227881077 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala --- @@ -38,6 +39,18 @@ object ReplaceExpressions extends Rule[LogicalPlan] { } } +/** --- End diff -- @cloud-fan We could also add these transformations in `ReplaceExpressions` rule and not require a dedicated rule (fyi).
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org