Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22814#discussion_r228063724
--- Diff:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroCatalystDataConversionSuite.scala
---
@@ -17,30 +17,49 @@
package org.apache.spark.sql.avro
+import org.apache.avro.Schema
+
import org.apache.spark.SparkFunSuite
-import org.apache.spark.sql.RandomDataGenerator
+import org.apache.spark.sql.{RandomDataGenerator, Row}
import org.apache.spark.sql.catalyst.{CatalystTypeConverters, InternalRow}
import org.apache.spark.sql.catalyst.expressions.{ExpressionEvalHelper,
GenericInternalRow, Literal}
import org.apache.spark.sql.catalyst.util.{ArrayBasedMapData,
GenericArrayData, MapData}
+import org.apache.spark.sql.test.SharedSQLContext
import org.apache.spark.sql.types._
-class AvroCatalystDataConversionSuite extends SparkFunSuite with
ExpressionEvalHelper {
+class AvroCatalystDataConversionSuite extends SparkFunSuite
+ with SharedSQLContext
+ with ExpressionEvalHelper {
private def roundTripTest(data: Literal): Unit = {
val avroType = SchemaConverters.toAvroType(data.dataType,
data.nullable)
checkResult(data, avroType.toString, data.eval())
}
private def checkResult(data: Literal, schema: String, expected: Any):
Unit = {
- checkEvaluation(
- AvroDataToCatalyst(CatalystDataToAvro(data), schema),
- prepareExpectedResult(expected))
+ Seq("FAILFAST", "PERMISSIVE").foreach { mode =>
--- End diff --
why do we test 2 modes here? The mode is for when failure happens, but
`checkResult` is for when no failures.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
