Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22812#discussion_r228195016
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
 ---
    @@ -119,10 +119,9 @@ object ExpressionEncoder {
         }
     
         val childrenDeserializers = encoders.zipWithIndex.map { case (enc, 
index) =>
    -      val getColumnsByOrdinals = enc.objDeserializer.collect { case c: 
GetColumnByOrdinal => c }
    -        .distinct
    -      assert(getColumnsByOrdinals.size == 1, "object deserializer should 
have only one " +
    -        s"`GetColumnByOrdinal`, but there are 
${getColumnsByOrdinals.size}")
    +      val getColExprs = enc.objDeserializer.collect { case c: 
GetColumnByOrdinal => c }.distinct
    --- End diff --
    
    unrelated but to fix minor code style issues in 
https://github.com/apache/spark/pull/22749


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to