Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22809#discussion_r228229829
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Max.scala
 ---
    @@ -57,3 +57,34 @@ case class Max(child: Expression) extends 
DeclarativeAggregate {
     
       override lazy val evaluateExpression: AttributeReference = max
     }
    +
    +abstract class AnyAggBase(arg: Expression)
    --- End diff --
    
    @mgaido91 I had a confusion on where to house this class ? Is it okay if i 
just rename it and keep it in Max.scala ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to