GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/22840
[SPARK-25840][BUILD] `make-distribution.sh` should not fail due to missing
LICENSE-binary
## What changes were proposed in this pull request?
We vote for the artifacts. All releases are in the form of the source
materials needed to make changes to the software being released.
(http://www.apache.org/legal/release-policy.html#artifacts)
From Spark 2.4.0, the source artifact and binary artifact starts to contain
own proper LICENSE files (LICENSE, LICENSE-binary). It's great to have them.
However, unfortunately, `dev/make-distribution.sh` inside source artifacts
start to fail because it expects `LICENSE-binary` and source artifact have only
the LICENSE file.
https://dist.apache.org/repos/dist/dev/spark/v2.4.0-rc4-bin/spark-2.4.0.tgz
`dev/make-distribution.sh` is used during the voting phase because we are
voting on that source artifact instead of GitHub repository. Individual
contributor usually don't have the downstream repository and starts to try
build the voting source artifacts. (Personally, I did before.)
This PR aims to recover that script to work in any way. This doesn't aim
for source artifacts to reproduce the compiled artifacts.
## How was this patch tested?
Manual.
```
$ rm LICENSE-binary
$ dev/make-distribution.sh
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-25840
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22840.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22840
----
commit 0950bb86ac028655c665687398c7dcfce1853f04
Author: Dongjoon Hyun <dongjoon@...>
Date: 2018-10-25T21:06:41Z
[SPARK-25840][BUILD] `make-distribution.sh` should not fail due to missing
LICENSE-binary
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
