Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22624#discussion_r228400112
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/security/KubernetesHadoopDelegationTokenManager.scala
 ---
    @@ -18,45 +18,20 @@
     package org.apache.spark.deploy.k8s.security
     
     import org.apache.hadoop.conf.Configuration
    -import org.apache.hadoop.fs.FileSystem
    -import org.apache.hadoop.security.{Credentials, UserGroupInformation}
    +import org.apache.hadoop.security.UserGroupInformation
     
     import org.apache.spark.SparkConf
    -import org.apache.spark.deploy.SparkHadoopUtil
     import org.apache.spark.deploy.security.HadoopDelegationTokenManager
    -import org.apache.spark.internal.Logging
     
     /**
    - * The KubernetesHadoopDelegationTokenManager fetches Hadoop delegation 
tokens
    - * on the behalf of the Kubernetes submission client. The new credentials
    - * (called Tokens when they are serialized) are stored in Secrets 
accessible
    - * to the driver and executors, when new Tokens are received they 
overwrite the current Secrets.
    + * Adds Kubernetes-specific functionality to HadoopDelegationTokenManager.
      */
     private[spark] class KubernetesHadoopDelegationTokenManager(
    --- End diff --
    
    this class doesn't really seem necessary anymore, but not a big deal


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to