Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22823#discussion_r228407600
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -910,12 +910,14 @@ class CodegenContext {
val blocks = new ArrayBuffer[String]()
val blockBuilder = new StringBuilder()
var length = 0
+ val splitThreshold =
+ SQLConf.get.getConfString("spark.testing.codegen.splitThreshold",
"1024").toInt
--- End diff --
Personally I don't think this is a good solution:
1. The configuration contains "testing", which is super wired as it can be
used in production.
2. We should start a new discuss about whether to make it configurable. The
reason should not be making the benchmark easier.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
