GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/22858
[SPARK-24709][SQL][2.4] use str instead of basestring
## What changes were proposed in this pull request?
after backport https://github.com/apache/spark/pull/22775 to 2.4, the 2.4
sbt Jenkins QA job is broken, see
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test/job/spark-branch-2.4-test-sbt-hadoop-2.7/147/console
I checked all the `isinstance` calls in `functions.py`, all of them use
`str` to check string type. I don't know why `basestring` works in master and
2.4 maven build, but it's safer to follow exiting code.
## How was this patch tested?
existing test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark python
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22858.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22858
----
commit 2917acd18994c3901c8c5b562cf87964bca879d9
Author: Wenchen Fan <wenchen@...>
Date: 2018-10-27T11:12:10Z
use str instead of basestring
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
