Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22858#discussion_r228731178
--- Diff: python/pyspark/sql/functions.py ---
@@ -2326,7 +2326,7 @@ def schema_of_json(json):
>>> df.select(schema_of_json('{"a": 0}').alias("json")).collect()
[Row(json=u'struct<a:bigint>')]
"""
- if isinstance(json, basestring):
+ if isinstance(json, str):
--- End diff --
Yea we should. They are put only when it's needed because there are so many
cases like that (for instance, imap in Python 2 and map in Python 3)
Looks that's added in another PR in master beach only.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
