Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22865#discussion_r228731385
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -462,7 +462,7 @@ object SQLConf {
       val PARQUET_RECORD_FILTER_ENABLED = 
buildConf("spark.sql.parquet.recordLevelFilter.enabled")
         .doc("If true, enables Parquet's native record-level filtering using 
the pushed down " +
           "filters. This configuration only has an effect when 
'spark.sql.parquet.filterPushdown' " +
    -      "is enabled.")
    +      "is enabled and spark.sql.parquet.enableVectorizedReader is 
disabled.")
    --- End diff --
    
    I didn't document this intentionally because 
`spark.sql.parquet.enableVectorizedReader` can be disabled for other conditions 
even if it's enabled (like for complex types).
    
    Shall we clearly document this?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to