Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22666#discussion_r228787018
  
    --- Diff: sql/core/src/test/resources/sql-tests/inputs/csv-functions.sql ---
    @@ -7,3 +7,11 @@ select from_csv('1', 'a InvalidType');
     select from_csv('1', 'a INT', named_struct('mode', 'PERMISSIVE'));
     select from_csv('1', 'a INT', map('mode', 1));
     select from_csv();
    +-- infer schema of json literal
    +select from_csv('1,abc', schema_of_csv('1,abc'));
    +select schema_of_csv('1|abc', map('delimiter', '|'));
    +select schema_of_csv(null);
    +CREATE TEMPORARY VIEW csvTable(csvField, a) AS SELECT * FROM VALUES 
('1,abc', 'a');
    +SELECT schema_of_csv(csvField) FROM csvTable;
    +-- Clean up
    +DROP VIEW IF EXISTS csvTable;
    --- End diff --
    
    actually we don't need to clean up temp views. The golden file test is run 
with a fresh session.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to