Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22868#discussion_r229051205
  
    --- Diff: docs/sql-migration-guide-hive-compatibility.md ---
    @@ -53,7 +53,20 @@ Spark SQL supports the vast majority of Hive features, 
such as:
     * View
       * If column aliases are not specified in view definition queries, both 
Spark and Hive will
         generate alias names, but in different ways. In order for Spark to be 
able to read views created
    -    by Hive, users should explicitly specify column aliases in view 
definition queries.
    +    by Hive, users should explicitly specify column aliases in view 
definition queries. As an
    +    example, Spark cannot read `v1` created as below by Hive.
    +
    +    ```
    +    CREATE TABLE t1 (c1 INT, c2 STRING);
    +    CREATE VIEW v1 AS SELECT * FROM (SELECT c1 + 1, upper(c2) FROM t1) t2;
    --- End diff --
    
    nit : We could perhaps simplify the query to : 
    ```
    CREATE VIEW v1 AS (SELECT c1 + 1, upper(c2) FROM t1);
    ```
    what do you think ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to