Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22713#discussion_r229307114
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
 ---
    @@ -604,4 +606,28 @@ class AnalysisSuite extends AnalysisTest with Matchers 
{
           checkAnalysis(input, expected)
         }
       }
    +
    +  test("SPARK-25691: AliasViewChild with different nullabilities") {
    +    object ViewAnalyzer extends RuleExecutor[LogicalPlan] {
    +      val batches = Batch("View", Once, AliasViewChild(conf), 
EliminateView) :: Nil
    +    }
    +    def intNotNullableAttr(name: String): Attribute = {
    +      AttributeReference(name, IntegerType, nullable = false)()
    +    }
    +    val relation = LocalRelation(intNotNullableAttr("a"), 'b.string)
    --- End diff --
    
    nit: `'a.int.notNull`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to