Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22788#discussion_r229578738
--- Diff:
sql/core/src/test/resources/sql-tests/results/columnresolution-negative.sql.out
---
@@ -161,7 +161,7 @@ SELECT db1.t1.i1 FROM t1, mydb2.t1
struct<>
-- !query 18 output
org.apache.spark.sql.AnalysisException
-cannot resolve '`db1.t1.i1`' given input columns: [mydb2.t1.i1,
mydb2.t1.i1]; line 1 pos 7
+cannot resolve '`db1`.`t1`.`i1`' given input columns: [mydb2.t1.i1,
mydb2.t1.i1]; line 1 pos 7
--- End diff --
@cloud-fan I had a question, the 3rd example from huaxin, wanted to confirm
again if the output looks okay to you.
**from huaxin**
```
$"`a`.b".expr.asInstanceOf[org.apache.spark.sql.catalyst.analysis.UnresolvedAttribute].sql
```
with my previous fix:
```
`a`.`b`
```
make sql same as name:
```
a.b
```
Is it okay to drop the backtick from the first identifier ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
