Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22898#discussion_r229667653
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
@@ -124,14 +124,9 @@ object ExpressionEncoder {
s"`GetColumnByOrdinal`, but there are ${getColExprs.size}")
val input = GetStructField(GetColumnByOrdinal(0, schema), index)
- val newDeserializer = enc.objDeserializer.transformUp {
+ enc.objDeserializer.transformUp {
case GetColumnByOrdinal(0, _) => input
}
- if (schema(index).nullable) {
- If(IsNull(input), Literal.create(null, newDeserializer.dataType),
newDeserializer)
--- End diff --
good catch!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
