Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22892#discussion_r229671459
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -1063,21 +1067,19 @@ case class ShowCreateTableCommand(table:
TableIdentifier) extends RunnableComman
val dataSourceOptions = metadata.storage.properties.map {
case (key, value) => s"${quoteIdentifier(key)}
'${escapeSingleQuotedString(value)}'"
- } ++ metadata.storage.locationUri.flatMap { location =>
- if (metadata.tableType == MANAGED) {
- // If it's a managed table, omit PATH option. Spark SQL always
creates external table
- // when the table creation DDL contains the PATH option.
- None
- } else {
- Some(s"path
'${escapeSingleQuotedString(CatalogUtils.URIToString(location))}'")
- }
}
if (dataSourceOptions.nonEmpty) {
builder ++= "OPTIONS (\n"
builder ++= dataSourceOptions.mkString(" ", ",\n ", "\n")
builder ++= ")\n"
}
+
+ if (metadata.tableType == EXTERNAL) {
--- End diff --
shall we also make it a method like `showTableComment`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
